-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Apr 1, 2007, at 09:37, Tobias Nygren wrote:

> I've done some cleanup on my envctrl(sparc64) driver and would like
> someone to review it. One thing I'm not happy with right now is how
> pcfiic attaches to envctrl.
>
> ( Sources at http://netilium.org/~tnn/netbsd-envctrl/ )
>
> 1) Should pcf8584.c be moved from dev/i2c to dev/ic or it is fine
>   the way I implemented it?
> 2) In case of (1), should pcfiic attach through autoconf?
> 3) In case of (2), how should it attach?
> "pcfiic at ebus" doesn't make sense to me as the i2c bus should be
> internal to the envctrl driver. Another option would be
> "pcfiic at envctrl" but I'm not sure how to accomplish this.

Why keep the i2c bus private? Is there any chance that other devices 
may be present? Or that the same monitoring chips are used elsewhere? 
In my opinion i2c devices should be machine independent and live in 
dev/i2c.

> Another thing I'm pondering is if fan regulation should be
> disabled by default, and whether or not it should be a compile-time
> option or a sysctl knob.

I'm not sure wether my drivers are good examples ( probably not ) but - 
what would you win by not exposing it? I think until we have something 
more appropriate there should be sysctl knobs for things like 
temperature thresholds and the like.

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRg/hKspnzkX8Yg2nAQKoLwf+Omcy+2v3sNn9zwKsl0bqkzwKKgnhCMoH
2iow7scP/Rm3GD8oh+NYtSvsFZpOekegJKxwrgU7nmqF5pJsHgey10S83g2iKdjH
WayzokrdJKMtQMCXTd4EPqdOSHDIf1cShuD0ZYtLj2keO+fGzA6DkD/Y5dupadX1
BWJrx+Iyd0OgeTG422QpX5ZZFtxMXPv4flaim8b6/ZgJCMsNSrQUT8g3Cv0wCrfn
G8TiyatlnWIM5EWFX7IEZvX0EKDqdCF6XdqPXw5emEpalkzNlAK4vq4GQoAKn7gd
UQVRBJJbnchFoOPklKPKU4yftfe6jhseWaRs7fUd9FfMzeJsN6LaWg==
=h7g3
-----END PGP SIGNATURE-----