This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1295668080-1174611274=:29025
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.NEB.4.64.0703230929003.10985@localhost.>

On Fri, 16 Mar 2007, Iain Hibbert wrote:

>    I thought a while ago that it would be nice to standardize DPRINTF and
> DPRINTFN, and now that we have a <sys/debug.h> I've been pondering how we
> could integrate them, and make it easier to generate debug output. These
> are my thoughts so far:

Ok, I've been looking into this in more depth to see what works, and there
seem to be several possible directions:

1. add 'debug ??' statements as I originally planned
	this looks complex to implement, though it could represent a
	natural extension to the config(5) API

2. integrate with "options DEBUG"
	this is not bad, but it requires making 'options DEBUG' a
	magic option, in that config(1) takes note of it.
        I'm not sure if I like that yet, and its also complex..

and for both of these, there is some potential confusion about choosing an
attribute to debug against. Then I noticed DEBUGLIST, so:

3. integrate with "makeoptions DEBUGLIST="
	is what I was fiddling with last night, and something can be made
	very easily from a little make magic and a shell script..

I like this last because although maybe "per file" is overly fine grained,
its simple and doesn't break anything. modules can be upgraded to the new
API at their own pace, and the control mechanism can be upgraded later if
need be, without any more source changes.

I've attached a preliminary patch that seems to work ok, any comments?

iain

- if a mask is being used instead of levels, then DPRINTFN should go?
- more bit definitions?
- sysctl helper?
--0-1295668080-1174611274=:29025
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.64.0703231052130.1692@localhost.>
Content-Description: standard DPRINTF
Content-Disposition: attachment; filename=diff

LS0tIC91c3Ivc3JjL3N5cy9jb25mL01ha2VmaWxlLmtlcm4uaW5jCTIwMDct
MDEtMjcgMjM6Mzc6NDIuMDAwMDAwMDAwICswMDAwDQorKysgc3lzL2NvbmYv
TWFrZWZpbGUua2Vybi5pbmMJMjAwNy0wMy0yMyAwOToyMjowNy4wMDAwMDAw
MDAgKzAwMDANCkBAIC0xMDEsMTUgKzEwMSwyMSBAQA0KIENGTEFHUy5rZXJu
X3N5bmNoLmMrPQktZm5vLXJlb3JkZXItYmxvY2tzDQogLmVuZGlmDQogDQot
IyBVc2UgdGhlIHBlci1zb3VyY2UgQ09QVFMgdmFyaWFibGVzIHRvIGFkZCAt
ZyB0byBqdXN0IHRob3NlDQorIyBVc2UgdGhlIHBlci1zb3VyY2UgQ09QVFMg
dmFyaWFibGVzIHRvIGFkZCBkZWJ1ZyBvcHRpb25zIHRvIGp1c3QgdGhvc2UN
CiAjIGZpbGVzIHRoYXQgbWF0Y2ggdGhlIHNoZWxsIHBhdHRlcm5zIGdpdmVu
IGluICR7REVCVUdMSVNUfQ0KICMNCiAuZm9yIGkgaW4gJHtERUJVR0xJU1R9
DQogLiBmb3IgaiBpbiAke0NGSUxFUzpUOk0kaS5jfQ0KLUNPUFRTLiR7an0r
PS1nDQorQ09QVFMuJHtqfSs9LWcgLUREUFJJTlQ9ZGVidWdfJHtqOlJ9DQor
RFBSSU5UUys9JHtqOlJ9DQogLiBlbmRmb3INCiAuZW5kZm9yDQogDQorLmlm
ICFlbXB0eShEUFJJTlRTKQ0KK0NGSUxFUys9CWRlYnVnLmMNCitPQkpTKz0J
CWRlYnVnLm8NCisuZW5kaWYNCisNCiAjIGNvbXBpbGUgcnVsZXM6IHJ1bGVz
IGFyZSBuYW1lZCAke1RZUEV9XyR7U1VGRklYfSB3aGVyZSBUWVBFIGlzIE5P
Uk1BTCBvcg0KICMgTk9QUk9GIGFuZCBTVUZGSVggaXMgdGhlIGZpbGUgc3Vm
Zml4LCBjYXBpdGFsaXplZCAoZS5nLiBDIGZvciBhIC5jIGZpbGUpLg0KIE5P
Uk1BTF9DPz0JQCR7X01LU0hNU0d9ICJjb21waWxlICAkey5DVVJESVI6VH0v
JHsuVEFSR0VUfSI7IFwNCkBAIC0yODEsNiArMjg3LDE2IEBADQogIyBkZXBl
bmQgb24gbWF4dXNlcnMgYW5kIENQVSBjb25maWd1cmF0aW9uDQogYXNzeW0u
aCBtYWNoZGVwLm86IE1ha2VmaWxlDQogDQorIyBkZXBlbmQgZGVidWcuYw0K
Ky5pZiAhdGFyZ2V0KGRlYnVnLmMpDQorZGVidWcuYzogTWFrZWZpbGUgJFMv
Y29uZi9kZWJ1Zy5zaA0KKwkke19NS01TR19DUkVBVEV9IGRlYnVnLmMNCisJ
JHtIT1NUX1NIfSAkUy9jb25mL2RlYnVnLnNoICR7RFBSSU5UUzpPOnV9ID4g
ZGVidWcuYw0KKw0KK2RlYnVnLm86IGRlYnVnLmMNCisJJHtOT1JNQUxfQ30N
CisuZW5kaWYNCisNCiAjIw0KICMjICg3KSBtaXNjIHRhcmdldHM6IGluc3Rh
bGwsIGNsZWFuKGRpciksIGRlcGVuZChhbGwpLCBsaW50LCBsaW5rcywgdGFn
cywNCiAjIyAgICAgICAgICAgICAgICAgICBjc2NvcGUsIG1raWQNCi0tLSAv
ZGV2L251bGwJMjAwNy0wMy0yMyAxMDo0NjowNC4wMDAwMDAwMDAgKzAwMDAN
CisrKyBzeXMvY29uZi9kZWJ1Zy5zaAkyMDA3LTAzLTIzIDEwOjQxOjU5LjAw
MDAwMDAwMCArMDAwMA0KQEAgLTAsMCArMSwxMDAgQEANCisjIS9iaW4vc2gg
LQ0KKyMNCisjICROZXRCU0Q6IGRlYnVnLnNoJA0KKyMNCisjIENvcHlyaWdo
dCAoYykgMjAwNyBUaGUgTmV0QlNEIEZvdW5kYXRpb24sIEluYy4NCisjIEFs
bCByaWdodHMgcmVzZXJ2ZWQuDQorIw0KKyMgVGhpcyBjb2RlIGlzIGRlcml2
ZWQgZnJvbSBzb2Z0d2FyZSBjb250cmlidXRlZCB0byBUaGUgTmV0QlNEIEZv
dW5kYXRpb24NCisjIGJ5IElhaW4gSGliYmVydC4NCisjDQorIyBSZWRpc3Ry
aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3
aXRoIG9yIHdpdGhvdXQNCisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl
ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucw0KKyMg
YXJlIG1ldDoNCisjIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29k
ZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0DQorIyAgICBub3Rp
Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n
IGRpc2NsYWltZXIuDQorIyAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5
IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodA0KKyMg
ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv
bGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQ0KKyMgICAgZG9jdW1lbnRhdGlv
biBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRp
c3RyaWJ1dGlvbi4NCisjIDMuIEFsbCBhZHZlcnRpc2luZyBtYXRlcmlhbHMg
bWVudGlvbmluZyBmZWF0dXJlcyBvciB1c2Ugb2YgdGhpcyBzb2Z0d2FyZQ0K
KyMgICAgbXVzdCBkaXNwbGF5IHRoZSBmb2xsb3dpbmcgYWNrbm93bGVkZ2Vt
ZW50Og0KKyMgICAgICBUaGlzIHByb2R1Y3QgaW5jbHVkZXMgc29mdHdhcmUg
ZGV2ZWxvcGVkIGJ5IHRoZSBOZXRCU0QNCisjICAgICAgRm91bmRhdGlvbiwg
SW5jLiBhbmQgaXRzIGNvbnRyaWJ1dG9ycy4NCisjIDQuIE5laXRoZXIgdGhl
IG5hbWUgb2YgVGhlIE5ldEJTRCBGb3VuZGF0aW9uIG5vciB0aGUgbmFtZXMg
b2YgaXRzDQorIyAgICBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5k
b3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQNCisjICAgIGZyb20g
dGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4g
cGVybWlzc2lvbi4NCisjDQorIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVE
IEJZIFRIRSBORVRCU0QgRk9VTkRBVElPTiwgSU5DLiBBTkQgQ09OVFJJQlVU
T1JTDQorIyBgYEFTIElTJycgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQg
V0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQNCisjIFRP
LCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBB
TkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSDQorIyBQVVJQT1NFIEFSRSBE
SVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgVEhFIEZPVU5EQVRJT04g
T1IgQ09OVFJJQlVUT1JTDQorIyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1Qs
IElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9S
DQorIyBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5P
VCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRg0KKyMgU1VCU1RJVFVURSBH
T09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ
VFM7IE9SIEJVU0lORVNTDQorIyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FV
U0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJ
Tg0KKyMgQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElO
Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkNCisjIEFSSVNJTkcg
SU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBF
VkVOIElGIEFEVklTRUQgT0YgVEhFDQorIyBQT1NTSUJJTElUWSBPRiBTVUNI
IERBTUFHRS4NCisjDQorDQorIyMNCisjIyBmaWxlIGhlYWRlcg0KKyMjDQor
Y2F0IDw8IF9FT0YNCisvKg0KKyAqIE1BQ0hJTkUgR0VORVJBVEVEOiBETyBO
T1QgRURJVA0KKyAqDQorICogZGVidWcuYywgZnJvbSAkMA0KKyAqLw0KKw0K
KyNpbmNsdWRlIDxzeXMvcGFyYW0uaD4NCisjaW5jbHVkZSA8c3lzL3N5c2N0
bC5oPg0KKw0KK19FT0YNCisNCisjIw0KKyMjIHZhcmlhYmxlIGRlY2xhcmF0
aW9ucw0KKyMjDQorZm9yIGF0dHIgaW4gJEA7IGRvDQorICAgIGNhdCA8PCBf
RU9GDQoraW50IGRlYnVnXyRhdHRyOw0KK19FT0YNCitkb25lDQorDQorIyMN
CisjIyBzdGFydCBzeXNjdGwgc2V0dXANCisjIw0KK2NhdCA8PCBfRU9GDQor
DQorU1lTQ1RMX1NFVFVQKHN5c2N0bF9kZWJ1Z19zZXR1cCwgImRlYnVnIHN5
c2N0bCBzdWJ0cmVlIHNldHVwIikNCit7DQorDQorCXN5c2N0bF9jcmVhdGV2
KGNsb2csIDAsIE5VTEwsIE5VTEwsDQorCSAgICAJQ1RMRkxBR19QRVJNQU5F
TlQsDQorCSAgICAJQ1RMVFlQRV9OT0RFLCAiZGVidWciLCBOVUxMLA0KKwkg
ICAgCU5VTEwsIDAsIE5VTEwsIDAsDQorCSAgICAJQ1RMX0RFQlVHLCBDVExf
RU9MKTsNCitfRU9GDQorDQorIyMNCisjIyAgc3lzY3RsIGRlY2xhcmF0aW9u
cw0KKyMjDQorZm9yIGF0dHIgaW4gJEA7IGRvDQorICAgIGNhdCA8PCBfRU9G
DQorDQorCXN5c2N0bF9jcmVhdGV2KGNsb2csIDAsIE5VTEwsIE5VTEwsDQor
CQlDVExGTEFHX1BFUk1BTkVOVCB8IENUTEZMQUdfUkVBRFdSSVRFLA0KKwkJ
Q1RMVFlQRV9JTlQsICIkYXR0ciIsDQorCQlTWVNDVExfREVTQ1IoIiRhdHRy
LmMgZGVidWcgbGV2ZWwiKSwNCisJCU5VTEwsIDAsDQorCQkmZGVidWdfJGF0
dHIsIHNpemVvZihkZWJ1Z18kYXR0ciksDQorCQlDVExfREVCVUcsIENUTF9D
UkVBVEUsIENUTF9FT0wpOw0KK19FT0YNCitkb25lDQorDQorIyMNCisjIyBl
bmQgc3lzY3RsIHNldHVwDQorIyMNCitjYXQgPDwgX0VPRg0KK30NCitfRU9G
DQotLS0gL3Vzci9zcmMvc3lzL3N5cy9kZWJ1Zy5oCTIwMDctMDItMDkgMjE6
NTU6MzcuMDAwMDAwMDAwICswMDAwDQorKysgc3lzL3N5cy9kZWJ1Zy5oCTIw
MDctMDMtMjMgMTA6NDU6NDUuMDAwMDAwMDAwICswMDAwDQpAQCAtNTYsNCAr
NTYsNTAgQEANCiAjZGVmaW5lCUZSRUVDSEVDS19JTihoLCBhKQkvKiBub3Ro
aW5nICovDQogI2VuZGlmDQogDQorLyoNCisgKiBEZWJ1ZyBvdXRwdXQNCisg
Ki8NCisNCisjaWYgZGVmaW5lZChEUFJJTlQpDQorDQorZXh0ZXJuIGludCBE
UFJJTlQ7DQorDQorLyogZGVidWcgdGFncyAqLw0KKyNkZWZpbmUgREVCVUdf
V0FSTgkoMTw8MCkJLyogd2FybmluZ3MgKi8NCisjZGVmaW5lIERFQlVHX0lO
Rk8JKDE8PDEpCS8qIGluZm9ybWF0aW9uICovDQorI2RlZmluZSBERUJVR19E
QVRBCSgxPDwyKQkvKiBkYXRhIGZsb3cgKi8NCisNCisjZGVmaW5lIERQUklO
VEYoZm10LCBhcmdzLi4uKQlkbyB7CQkJXA0KKwlpZiAoRFBSSU5UKQkJCQkJ
XA0KKwkJcHJpbnRmKCIlczogImZtdCwgX19mdW5jX18gLCAjI2FyZ3MpOwlc
DQorfSB3aGlsZSAoLyogQ09OU1RDT05EICovMCkNCisNCisjZGVmaW5lIERQ
UklOVEZOKG4sIGZtdCwgYXJncy4uLikJZG8gewkJXA0KKwlpZiAoKERQUklO
VCkgJiAoMSA8PCAobikpKQkJCVwNCisJCXByaW50ZigiJXM6ICJmbXQsIF9f
ZnVuY19fICwgIyNhcmdzKTsJXA0KK30gd2hpbGUgKC8qIENPTlNUQ09ORCAq
LzApDQorDQorI2RlZmluZSBEUFJJTlRfV0FSTihmbXQsIGFyZ3MuLi4pCWRv
IHsJCVwNCisJaWYgKChEUFJJTlQpICYgREVCVUdfV0FSTikJCQlcDQorCQlw
cmludGYoIiVzOiAiZm10LCBfX2Z1bmNfXyAsICMjYXJncyk7CVwNCit9IHdo
aWxlICgvKiBDT05TVENPTkQgKi8wKQ0KKw0KKyNkZWZpbmUgRFBSSU5UX0lO
Rk8oZm10LCBhcmdzLi4uKQlkbyB7CQlcDQorCWlmICgoRFBSSU5UKSAmIERF
QlVHX0lORk8pCQkJXA0KKwkJcHJpbnRmKCIlczogImZtdCwgX19mdW5jX18g
LCAjI2FyZ3MpOwlcDQorfSB3aGlsZSAoLyogQ09OU1RDT05EICovMCkNCisN
CisjZGVmaW5lIERQUklOVF9EQVRBKGZtdCwgYXJncy4uLikJZG8gewkJXA0K
KwlpZiAoKERQUklOVCkgJiBERUJVR19EQVRBKQkJCVwNCisJCXByaW50Zigi
JXM6ICJmbXQsIF9fZnVuY19fICwgIyNhcmdzKTsJXA0KK30gd2hpbGUgKC8q
IENPTlNUQ09ORCAqLzApDQorDQorI2Vsc2UNCisjZGVmaW5lIERQUklOVEYo
Li4uKQ0KKyNkZWZpbmUgRFBSSU5URk4oLi4uKQ0KKyNkZWZpbmUgRFBSSU5U
X1dBUk4oLi4uKQ0KKyNkZWZpbmUgRFBSSU5UX0lORk8oLi4uKQ0KKyNkZWZp
bmUgRFBSSU5UX0RBVEEoLi4uKQ0KKyNlbmRpZg0KKw0KICNlbmRpZgkvKiBf
X1NZU19ERUJVR19IX18gKi8NCg==

--0-1295668080-1174611274=:29025--