Subject: Re: if_media and 802.11
To: None <tech-kern@NetBSD.org>
From: David Young <dyoung@pobox.com>
List: tech-kern
Date: 02/16/2007 04:11:59
On Fri, Feb 16, 2007 at 01:56:09AM -0800, Matt Thomas wrote:
> On Feb 16, 2007, at 12:43 AM, David Young wrote:
> >
> >        #define IEEE80211_IOC_HT        TBD
> >
> >        struct ieee80211_ht_req {
> >                char                            i_name[IFNAMSIZ];
> >                uint16_t                        i_type;
> >                struct ieee80211_ht_params      *i_param;
> 
> This should not be a pointer.  It'd be best if the ioctl can avoid  
> secondary copyins or copyouts.

I wrote it that way because if we put the new ioctl into the
IEEE80211_IOC_ space as I propose, then ieee80211_ht_req can be no bigger
than ieee80211req:

struct ieee80211req {
        char            i_name[IFNAMSIZ];       /* if_name, e.g. "wi0" */
        u_int16_t       i_type;                 /* req type */          
        int16_t         i_val;                  /* Index or simple value */
        int16_t         i_len;                  /* Index or simple value */
        void            *i_data;                /* Extra data */        
};      

Dave

-- 
David Young             OJC Technologies
dyoung@ojctech.com      Urbana, IL * (217) 278-3933