Subject: Re: Adding /proc/swaps to linux compat code
To: Christos Zoulas <christos@astron.com>
From: Arnaud Lacombe <arnaud.lacombe.1@ulaval.ca>
List: tech-kern
Date: 01/31/2007 12:20:39
patch updated (same url).

On Wed, Jan 31, 2007 at 04:43:42PM +0000, Christos Zoulas wrote:
> - Don't cast the result of malloc.
done

> - Assign buflen to LBFSZ in the beginning and use buflen from now on,
>   instead of of LBFSZ.
done

> - Missing spaces count=nswap, should be changed anyway read on.
> - count should be register_t, and you should check it against nswap
>   and use it if <= instead of ignoring it.
oups :/ some fallout of debugging :)

> - it would be nice to have an api to get the blocksize... but this is
>   ok for now.
I'll have a look at it this week-end

btw, is there a reason to compile linux /proc stuff even when
COMPAT_LINUX is commented in config file ?

 - Arnaud