Subject: Re: Removig generic optstr_get
To: Pavel Cahyna <email@example.com>
From: Quentin Garnier <firstname.lastname@example.org>
Date: 10/25/2006 00:44:52
Content-Type: text/plain; charset=us-ascii
On Tue, Oct 24, 2006 at 10:20:49PM +0200, Pavel Cahyna wrote:
> On Tue, Oct 24, 2006 at 02:46:18PM +0200, Julio M. Merino Vidal wrote:
> > Hello,
> > [ please CC me any replies ]
> > When the Multiboot code was added, I also added a generic function
> > (optstr_get) used to parse "option strings" of the form: "a=3Db c=3Dd .=
> > x=3Dy" The idea was to later use this interface in other places such as
> > the mount options passed during a mount(2).
> > Since then, proplib was added which completely replaces this idea with
> > a more powerful framework (not to mention that the optstr_get
> > interface was probably suboptimal). Therefore I'd like to do some
> > cleanup:
> > - Remove kern/subr_optstr.c and related manual pages and headers.
> > - Move optstr_get into arch/i386/i386/multiboot.c and make it static,
> > as this is the only place where this functionality is used. (And I gu=
> > it shouldn't be used anywhere else thanks to proplib.)
> > Objections?
> Is there a real need for this change? I would prefer leaving things as
> they are now.
> (We might want to support richer boot parameters with other boot methods
> than Multiboot one day.)
And proplib will still be there for that.
Quentin Garnier - email@example.com - cube@NetBSD.org
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (NetBSD)
-----END PGP SIGNATURE-----