Subject: Re: RTL8169 hw IP4CSUM_Tx workaround
To: None <,>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
List: tech-kern
Date: 10/22/2006 22:01:35
>> +	/*
>> +	 * Walk packet chain to find last mbuf. We will either
>> +	 * pad there, or append a new mbuf and pad it.
>> +	 */
>> +	for (m_last = pkt; m_last->m_next != NULL; m_last = m_last->m_next)
>> +		continue;
> I'm not exactly thrilled with walking the packet chain...

I don't see it as a big deal.  THis is done only for packets small
enough to need padding; the mbuf chain is unlikely to contain more than
one or two mbufs, no?

Also, I'm not sure what the alternative is.  Get corrupted packets
fast?  I don't see that as better.  (K&P, from memory: "Presumably this
means it is important to get the wrong answers quickly.")

/~\ The ASCII				der Mouse
\ / Ribbon Campaign
 X  Against HTML
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B