Subject: Re: Removing tmpfs' experimental status
To: Julio M. Merino Vidal <firstname.lastname@example.org>
From: Elad Efrat <elad@NetBSD.org>
Date: 10/22/2006 18:17:57
Julio M. Merino Vidal wrote:
> On 10/22/06, Elad Efrat <email@example.com> wrote:
>> Julio M. Merino Vidal wrote:
>> > - Enable TMPFS by default on all GENERIC kernels.
>> Are you going to disable MFS by default too?
Why not? I thought we don't want bloat in our kernel?
>> > - Disable the tmpfs_vfstofh and tmpfs_fhtovfs vfsops so that tmpfs
>> > does not support exporting. (I'm making them optional through a
>> > TMPFS_ENABLE_NFS macro so that people interested in fixing it can
>> > quickly enable the missing bits. Of course the macro will go away
>> > when things work as expected.)
>> Please don't do that.
> Why not? It's just the same as an "#ifdef notyet" but with a more
> meaningful name. That macro will NOT go into any kernel
> configuration, and it shouldn't be set there. People interested in
> fixing this stuff should '#define TMPFS_ENABLE_NFS' explicitly in the
> .c file.
Please check what happens with fileassoc(9) on tmpfs file-systems with
this disabled before adding these options.