On Saturday 14 October 2006 09:17, David Laight wrote:

> I think you need to add code to stop other parts of the system trying
> to use non-512 byte sectors.  At least until the 'correct' disk
> formats have been determined.
> For instance all the code to access mbr extended partitions is likely
> wrong. and anything to do with UFS.

Well, addressing the latter is best done as part of dealing with the 
whole fixed DEV_BSIZE problem. I'm not going there right now (if ever).

> IMHO disklabels should be specified is the units that the disklabel
> reports as the sector size.  With the requirement that all partition
> boundaries be on physical sector boundaries.

I'm inclined to agree. But the translation into DEV_BSIZE units must have 
been there for a reason. I'll remove it locally to see what breaks.

Cheers, Steve