Subject: Re: root configuration with multiple root-enabled RAID sets
To: Emmanuel Dreyfus <firstname.lastname@example.org>
From: Christos Zoulas <email@example.com>
Date: 10/12/2006 08:42:54
On Oct 12, 8:42am, firstname.lastname@example.org (Emmanuel Dreyfus) wrote:
-- Subject: Re: root configuration with multiple root-enabled RAID sets
| > >Is it okay to commit that?
| > Why did you change #ifdef DEBUG -> #if DEBUG?
| It's the other way around: I changed to #ifdef instead of #if. My
| toolchain wanted the change in order to build. I suspect it's because of
| the #define DEBUG I added at the top of the file.
| But that's orthogonal to the real problem. If I commit that change, that
| will be without the #define DEBUG at the top, and I can probably keep
| the #if DEBUG untouched in that case.
#ifdef DEBUG is better in the long run; you should commit this in a separate