Subject: Re: uobj_wirepages/unwirepages
To: None <unex@linija.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 10/10/2006 11:19:33
thanks for working on it.

> 	int i, npages = FETCH_PAGECOUNT, error;

this initialization of "npages" seems redundant.

> 		/* Unwire the pages */

s/Unwire/Wire/

> error:
> 	/* Unwire the pages which has been wired */
> 	uobj_unwirepages(uobj, offset, end);

uobj_unwirepages(uobj, start, offset);

> +/* uvm_object.c */
> +int			uobj_wirepages(struct uvm_object *uobj, off_t start,
> +			    off_t end);
> +void			uobj_unwirepages(struct uvm_object *uobj, off_t start,
> +			    off_t end);

> +/*
> + * prototypes
> + */
> +
> +int uobj_wirepages(struct uvm_object *uobj, off_t start, off_t end);
> +void uobj_unwirepages(struct uvm_object *uobj, off_t start, off_t end);

either of them should be enough.

YAMAMOTO Takashi