Subject: Re: CVS commit: src/sys
To: None <tls@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 10/06/2006 12:16:54
> > Module Name: src
> > Committed By: tls
> > Date: Thu Oct 5 17:35:20 UTC 2006
> >
> > Modified Files:
> > src/sys/dev/raidframe: rf_diskqueue.c rf_netbsdkintf.c
> > src/sys/net: if_bridge.c route.c
> > src/sys/netinet: igmp.c in.c in_pcb.c ip_flow.c ip_input.c raw_ip.c
> > tcp_input.c tcp_sack.c tcp_subr.c tcp_usrreq.c udp_usrreq.c
> > src/sys/netinet6: in6_pcb.c
> >
> > Log Message:
> > Protect calls to pool_put/pool_get that may occur in interrupt context
> > with spl used to protect other allocations and frees, or datastructure
> > element insertion and removal, in adjacent code.
>
> are redundant spl operations intentional?
> ie. is it ok to back out redundant ones?
btw, the "do we trust all callers of tcp_close()?" comment in tcp_close
means you added this splsoftnet() by guessing, without checking callers?
YAMAMOTO Takashi