Subject: Re: Status report: sysmon_cpufreq(9) + powerctl(8)
To: Jachym Holecek <email@example.com>
From: Juan RP <firstname.lastname@example.org>
Date: 09/28/2006 19:40:55
On Thu, 28 Sep 2006 19:33:59 +0200
Jachym Holecek <email@example.com> wrote:
> # Juan RP 2006-09-28:
> > Anyway there are some problems in the code that I need to fix...
> > when I set a frequency in a specified driver, it removes the
> > dictionary and consequent calls will panic because I think it
> > removes device_t's properties dictionary by accident... I don't
> > know where's the problem.
> You mean in SMCPUFREQ_SFREQ case? At a glance: you assign obj to
> sdict["list-of-frequencies"] array and when you're done with it,
> you release obj. But you didn't retain it previously, so you might
> be dropping the last reference in which case the array is GC'd.
Yes, in the SMCPUFREQ_SFREQ case, calling SMCPUFREQ_GDICT works fine.
I'll take a look, thanks.