Subject: Re: CVS commit: src/sys/dev
To: None <christos@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 08/28/2006 20:18:25
> Module Name:	src
> Committed By:	christos
> Date:		Sun Aug 27 18:45:20 UTC 2006
> 
> Modified Files:
> 	src/sys/dev: vnd.c
> 
> Log Message:
> PR/34293: Michael van Elst: vnd deadlocks on I/O buffers
> Also fixes: PR/10731, PR/12189, PR/20296
> Sleep while there a buffer shortage.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.148 -r1.149 src/sys/dev/vnd.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

- isn't d_strategy expected to be interrupt-safe?
- is "vnd->sc_maxactive > 0" check necessary?
- to me, it isn't clear how this fixes the problem,
  given that vndthread already has its own check of sc_maxactive.

YAMAMOTO Takashi