Subject: Re: fileassoc (Re: CVS commit: src)
To: YAMAMOTO Takashi <email@example.com>
From: Elad Efrat <elad@NetBSD.org>
Date: 07/16/2006 10:57:33
YAMAMOTO Takashi wrote:
> - as far as you use VOPs in the framework, i guess you need some kind of
> locking rules.
i only use VOP_GETATTR(). or..?
> - fileassoc_file_delete in sys_unlink:
> - is it intended to call it whenever a link to a file is removed?
no, and that's a valid concern for the veriexec hook too. perhaps we
should check the link count? any suggestion?
> - i don't think nd.ni_vp is always valid after VOP_REMOVE.
i tried to place it in a spot where it will only be entered if the file
was removed. any suggestion?
> - please make fileassoc.h minimal.
> - unexport functions and structures which aren't necessary to be
> eg. fileassoc_init (use static initialization or RUN_ONCE),
> fileassoc_file_lookup, fileassoc_hash_entry.
why not export fileassoc_file_lookup? it's used in the veriexec code.
as for the structs, i know they shouldn't be exported, i just haven't
had the time yet to look into it.