Subject: Re: file id alignment
To: None <email@example.com>
From: YAMAMOTO Takashi <firstname.lastname@example.org>
Date: 07/13/2006 12:45:10
> > - i think you need to check nfsrv_descript.nd_fh.
> As I said initialy: I'm pretty much lost in the NFS part of the change.
> I've attached a modified version (only the nfs part this time)
seems fine to me.
> > - i'm not sure ENOMEM is an appropriate error code for too big filehandles.
> Any better suggestions?
E2BIG as iconv(3) does?
ENOMEM sounds like memory allocation failure to me.
> > - is it ok to use c99 feature for an userland-exported header?
> > (a flexible array member in struct fid)
> IMHO it is (didn't we get rid of gcc 2.95.x now?). Are there alternatives?
> I don't like "char fid_data", when "2" is just a lie.
maybe it's ok as far as it can be compiled with -std=c89 or -std=gnu89.