Subject: vnode locking in kern/vfs_syscalls.c looks inconsistent
To: None <>
From: Roland Illig <>
List: tech-kern
Date: 07/03/2006 07:55:33

the vnode locking in the change_mode function looks very strange to me. 
It is locked by vn_lock(), but unlocked by VOP_UNLOCK().

Can someone who knows please explain why the combination 
vn_lock/vn_unlock or VOP_LOCK/VOP_UNLOCK cannot be used here? The CVS 
log does not explain it.

Oh, I'm just seeing that there is no function called vn_unlock. 
Shouldn't there be one just to make the code nice-looking?