Subject: Re: com rumblings...
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: tech-kern
Date: 06/16/2006 09:20:31
Izumi Tsutsui wrote:
> thorpej@shagadelic.org wrote:
>
>
>>> Why don't you make them wrapper functions which prepare struct softc?
>>> How about structures like this?
>>>
>> I think it would be a good idea to get away from creating fake softcs.
>>
>
> Hmm, my intention to create fake softcs is to make
> CSR_{READ,WRITE} macros take softc as most drivers do.
> If it's okay to make them take struct com_regs, faked one
> isn't needed. (I don't have strong insistence which is better)
>
FWIW, if I were dealing with a sane driver where nearly all routines had
the softc passed in, I would have made CSR_READ/WRITE take that softc.
But since there were a number of functions that operate without a softc
(basically the console stuff), I decided it was better to create a
structure that had only the data in it needed for the console.
-- Garrett
> ---
> Izumi Tsutsui
>
--
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134 Fax: 951 325-2191