Subject: Re: splraiseipl()
To: None <email@example.com>
From: YAMAMOTO Takashi <firstname.lastname@example.org>
Date: 05/08/2006 10:58:19
> > - patch attached to this mail. please test/review.
> > luna68k
> > next68k
> > news68k
> Looks fine and works on my NWS-1750, while I have a few comments:
> - style of '#define<space>' or '#define<tab>' shouldn't be changed
> in each file
then i'll change all of them to use "#define<tab>". ok?
> - is splsoft() still needed?
i don't know.
> - do you have any idea for hp300? should all spl levels refer hp300_ipls?
do you mean how to implement splraiseipl() for hp300?
it can be similar to mac68k, i guess.
> i.e. no way to prepare level specific macros?
what's level specific macro?
> - it looks weird a bit to define IPL_* macro as (PSL_S|PSL_IPL?)
> because IPL_* macros are used to specify interrupt priority order
> on some ports (hp300, some mips etc).
how are hp300 and mips related to this patch?
> is it better to introduce some other opaque macros like SPL_*
> as you have asked in your first post?
> (those macro may be passed to MD splraise functions directly)
maybe. see PR/33218 for a reason.