Quentin Garnier <cube@cubidou.net> writes:

> Hi folks,
>
> While I'm glad auich.c has been fixed for some motherboards, I'm a bit
> disgusted by the use of raw IDs for sub-vendor and sub-product matching.
>
> I'm proposing the attached patch to store them in pcidevs (and I leave
> the auich.c changes as an exercise to the reader).  I'm not 100%
> positive that the 0x161f sub-vendor ID used in auich.c is always
> Rioworks but I'd say it's likely enough to be true.  The patch leaves
> the option to have "subvendor" entries, anyway.

I like this change. I'm not an awk expert to comment on it, though.


> Should pci_findvendor(9) and pci_devinfo(9) be change to have one more
> parameter that asks for sub-product stuff, or can it wait for when it's
> actually useful?

What about adding pci_findsubvendor(), does it make sense ?
About pci_devinfo(), I'm not sure if we really need to change it now..

Thanks,
-- 
  Rui Paulo			<rpaulo@{NetBSD{,-PT}.org,fnop.net}>