On 2006-04-14 gdt@ir.bbn.com wrote:
> Christos Zoulas <christos@netbsd.org> writes:
>
> > Module Name:	src
> > Committed By:	christos
> > Date:		Fri Apr 14 17:07:23 UTC 2006
> >
> > Modified Files:
> > 	src/sys/dev/usb: ohci.c
> >
> > Log Message:
> > Coverity CID 1115: It is quite pointless to have a DIAGNOSTIC panic that
> > checks a variable for being NULL, and if we are not in DIAGNOSTIC code, to
> > just dereference it causing a crash!
> >
> > To generate a diff of this commit:
> > cvs rdiff -r1.171 -r1.172 src/sys/dev/usb/ohci.c

  I would guess it is referring to the fact that the variable was already
dereferenced before the DIAGNOSTIC check (there is another one in
usb_transfer_complete).

> Thanks for all the fixes, and for putting in descriptive CVS commit
> messages.   It will be very cool if all these end up fixing the ohci
> cardbus detach crash.

  Did you try the patch in kern/32011?  (I see now there is also
kern/26069; I'll add a note there too).

Matthew Orgass
darkstar@city-net.com