Subject: Re: loadelf_32.c: code review request: was=>Re: ia64 unwind
To: Jason Thorpe <thorpej@shagadelic.org>
From: Cherry G. Mathew <cherry@sdf.lonestar.org>
List: tech-kern
Date: 04/05/2006 07:08:29
On Tue, 2006-04-04 at 13:45 -0700, Jason Thorpe wrote:
> On Apr 1, 2006, at 11:13 AM, Cherry G. Mathew wrote:
> > +#ifdef MD_LOADSEG /* Allow processor ABI specific segment loads */
> > + if ( (phdr[i].p_type & PT_LOPROC) &&
> > + MD_LOADSEG(phdr[i]))
> > + goto loadseg;
> > +#endif /*MD_LOADSEG*/
>
> Does't it make sense to do >= LOPROC && <= HIPROC instead of testing
> a bit?
>
IMHO, Christos' suggestion to encapsulate the MD flag tests within
MD_LOADSEG() would be cleaner.
ie; if(MD_LOADSEG(&phdr[i]) goto loadseg;
--
~~Cherry