Subject: Re: two disks, two controlers, same bad block
To: None <>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
List: tech-kern
Date: 03/27/2006 13:13:59
> how much of an impact will that have on resources; "for every block
> read or write check if it requires LBA48," sounds kinda heavy.

We *already* do that.  It's just a question of drawing the line at
0xfffffff vs 0x10000000 - Seagate draws it one block earlier than they
should, and the quirk entry makes our driver match that.  The quirk
entry does complicate that check slightly, adding another bit test.

If you're that worried about efficiency, try changing the > to >= (to
make LBA48 kick in with sector 0xfffffff instead of 0x10000000) and
dropping the quirk.  See if it makes a measurable difference.  (I doubt
it will, but would love to hear from anyone with real measured data.)
It might break a non-LBA48-capable disk that's exactly 128G long, but I
am inclined to doubt any such exists.

/~\ The ASCII				der Mouse
\ / Ribbon Campaign
 X  Against HTML
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B