Subject: Re: SA under COMPAT_NETBSD32, a patch
To: Christos Zoulas <christos@astron.com>
From: Quentin Garnier <cube@cubidou.net>
List: tech-kern
Date: 03/16/2006 20:27:13
--BBpm95f3IOry5CQh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 16, 2006 at 06:31:59PM +0000, Christos Zoulas wrote:
> In article <20060316181030.GH307@gallia.cubidou.net>,
> Quentin Garnier  <cube@cubidou.net> wrote:
> >-=3D-=3D-=3D-=3D-=3D-
> >
> >Hi folks,
> >
> >Finally, I've made SA work for 32-bits binaries on sparc64 and amd64.
>=20
> Very nice!
>=20
> > - md.amd64.diff, md.sparc64.diff:  Changes to the affected platforms.
> >
> >             netbsd32_cpu_upcall() on sparc64 becomes the exact copy of
> >             sparc's cpu_upcall().
>=20
> Well, shouldn't you name _UC32_MACHINE_SP -> _UC_MACHINE32_SP like
> _UC_MACHINE32_PAD, or switch _UC_MACHINE32_PAD around to make them consis=
tent?

Yes, I should.

> > - sa.diff:
>=20
> Wou should cast getucontext not to (void *), but to (void (*)(struct lwp =
*, void *))

Oh, that's how you do it.  I had tried :)  Thanks.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--BBpm95f3IOry5CQh
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBRBm8EdgoQloHrPnoAQJGjgf/bvBZDzAjb0jLLG1DOsC6hw7CbrvyYwN1
yrW8Zwtx7GrRmnRPqCbNv2MQ6OljQQNPoaTxPTyvCNk238gYtI87kvn8jIp/dyaU
hMMUziYHkXyAw/rJRBkDcKQ+oUNr4iX3GjI8BQKFpmqFH/75ssZPi3nlXbH5JNPw
ssYHX4P68e+P/TIxFrGi3+MYjmfYiIYd/SDXk6veb3iDV0TvrpCSbI4li8y/k64W
c6Iyl4MUIh1ByeY/AjaZqiSCn/fefuuW39GeVAInLce17vLbo/VsUHJb8KkwWhQf
c3BhvrVCIhPoXQfT5lT74b6zYCF77I44h80qqeVyRrWOKLjvsjr88g==
=wk1L
-----END PGP SIGNATURE-----

--BBpm95f3IOry5CQh--