Subject: Re: SA under COMPAT_NETBSD32, a patch
To: None <>
From: Christos Zoulas <>
List: tech-kern
Date: 03/16/2006 18:31:59
In article <>,
Quentin Garnier  <> wrote:
>Hi folks,
>Finally, I've made SA work for 32-bits binaries on sparc64 and amd64.

Very nice!

> - md.amd64.diff, md.sparc64.diff:  Changes to the affected platforms.
>             netbsd32_cpu_upcall() on sparc64 becomes the exact copy of
>             sparc's cpu_upcall().

Well, shouldn't you name _UC32_MACHINE_SP -> _UC_MACHINE32_SP like
_UC_MACHINE32_PAD, or switch _UC_MACHINE32_PAD around to make them consistent?

> - sa.diff:

Wou should cast getucontext not to (void *), but to (void (*)(struct lwp *, void *))