Subject: Re: mcclock_isa.c unification
To: None <firstname.lastname@example.org>
From: Izumi Tsutsui <email@example.com>
Date: 03/13/2006 20:04:00
In article <XFMail.firstname.lastname@example.org>
> (I am not subscribed to tech-kern, so please CC me on replies)
Well, shouldn't you as a port maintainer? ;-p
> I was looking at mcclock_isa.c on port-prep today, and saw that many other
> ports had the same file. Looking at them, they all seem to be essentially the
> same code, in either different orders, or various stages of bitrot.
> I'm wondering if there is a technical reason we cannot make a unified
> mcclock_isa.c, and put it in dev/isa instead?
> Or am I missing something fundamental about how these are each MD?
Probe functions could be identical, but attach functions would
be different because:
- Some of those ports haven't switched to MI todr(9) (and MI mc146818.c)
and they still use their own old "struct clockfns" and MD mcclock.c
- The definition of "year of zero" is quite machine dependent
- Other configuration (BCD/BIN, 12H/24H etc.) could also be different
though the latter of two could be handled by device properties(9).