Subject: Re: explanation of PCI cardbus bridge code...
To: Garrett D'Amore <garrett_damore@tadpole.com>
From: Christopher SEKIYA <wileyc@rezrov.net>
List: tech-kern
Date: 02/21/2006 07:56:41
On Feb 21, 2006, at 12:54 AM, Garrett D'Amore wrote:

> Can anyone explain the following code:
>
> #if NIOAPIC > 0
>     printf("%s: using ioapic for interrupt\n", sc->sc_dev.dv_xname);
> #else
>     if ((0 == pa->pa_intrline) || (255 == pa->pa_intrline)) {
>             printf("%s: NOT USED because of unconfigured interrupt\n",
>             sc->sc_dev.dv_xname);
>         return;
>     }
> #endif

AFAICT the bit wrapped in #else was put in before we had a working  
interrupt fixup scheme.  It broke for machines that were using  
ioapic, hence the #if hackery.

> I think the above code is pretty PC-specific.  Can it be removed, or
> #ifdef i386'd?

Remove everything betwen #if and #endif -- it's obsolete.

-- Chris