> Isn't this plain wrong and an FFS-ism to assume that all but a VREG is a 
> DEV_BSHIFT length? Shouldn't those if's just be deleted? together with the 
> KASSERTS that demand it to be a VREG or VBLK ?

after all, genfs is filesystem-specific.
it might not match to your filesystem, but it doesn't mean it's wrong at all.
it's correct as far as it's used only for VREG and VBLK.
if you want to use this for other types, you need to modify it, of course.

YAMAMOTO Takashi