> Dear folks,
> 
> running trough sys/kern/vnode_if.src to lookup the locking protocol for 
> VOP_BMAP i stumbled on:
> 
> #
> #% bmap               vp      = = =
> #% bmap               vpp     - U -
> #       
> vop_bmap {
>         IN LOCKED=YES struct vnode *vp;
>         IN daddr_t bn;
>         OUT struct vnode **vpp;
>         IN daddr_t *bnp;
>         OUT int *runp;
> };
> 
> Wich is an inconsistency. The first part indicates the locking is not 
> relevant but shouldn't change and the second part of the description tells 
> that struct vnode *vp should be locked on entry!

fixed.

> One of the others i've found is
> 
> #
> #% strategy   vp      = = =
> #       
> vop_strategy {
>         IN struct vnode *vp;
>         IN struct buf *bp;
> }; 
> 
> Shouldn't that be "L L L" for *vp ?

no.  why do you think so?

YAMAMOTO Takashi