--i9LlY+UWpKt15+FH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Dear folks,

running trough sys/kern/vnode_if.src to lookup the locking protocol for 
VOP_BMAP i stumbled on:

#
#% bmap               vp      = = =
#% bmap               vpp     - U -
#       
vop_bmap {
        IN LOCKED=YES struct vnode *vp;
        IN daddr_t bn;
        OUT struct vnode **vpp;
        IN daddr_t *bnp;
        OUT int *runp;
};

Wich is an inconsistency. The first part indicates the locking is not 
relevant but shouldn't change and the second part of the description tells 
that struct vnode *vp should be locked on entry!

One of the others i've found is

#
#% strategy   vp      = = =
#       
vop_strategy {
        IN struct vnode *vp;
        IN struct buf *bp;
}; 

Shouldn't that be "L L L" for *vp ?

puzzled,
Reinoud

--i9LlY+UWpKt15+FH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ7RmWIKcNwBDyKpoAQLpqAgAqI2KxnevhGTztWG8ssE2G9FvOSNKIsZJ
nZVwrCEMrP/dndJy26YdIQvb9jGnFgWxLQ0zQQvxMdAx8zd6s1oX84ZKrY6Q19Q5
1ZtHn3ZbXOUO4M9q2PKhfTFwzgyM210WNBpsxb8ElsAtip7cEwa1/SF5q7f5XHD0
E4PycK051QyJzcc+lT66euZiN6QQKmbYh5MycPpWjmaLC6LuDSOuViVQ9YGgkCIk
QpvbzSVFHu/pcNCP+rsWPxqJkEo3JCMtGpZ+4mhA9Kz8w/b7fqJnvChSf4BF74yI
IzxYrtfQaDcaZonIJTzm/D2bvdFd04ybpXrV8/vIU4P6TILpCTJ1Wg==
=MIwo
-----END PGP SIGNATURE-----

--i9LlY+UWpKt15+FH--