Subject: Re: SCSI MMC device abstraction and UDF patch for review
To: Christos Zoulas <firstname.lastname@example.org>
From: Reinoud Zandijk <email@example.com>
Date: 12/21/2005 21:25:33
Content-Type: text/plain; charset=us-ascii
On Wed, Dec 21, 2005 at 06:45:14PM +0000, Christos Zoulas wrote:
> In article <Pine.LNX.firstname.lastname@example.org>,
> - The -m flag should be split to -u uid, -g gid like the other mount calls.
as replied before to Hubert, yeah this makes sense indeed.
> These are many minor nits; in general it is fine!
Thanks, i'll try to address these `nits' soon. KNF at times bites me :(
esp. some indenting rules are not consistent/logical but try to stick to
them. Can't say it helps readability... esp. the rules on splitting lines
are a bit weird and the resulting code looks `funny' and isn't that
readable to me. Normally i try to go for readability first in my indenting.
Will keep you informed,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
-----END PGP SIGNATURE-----