Subject: Re: SCSI MMC device abstraction and UDF patch for review
To: Christos Zoulas <christos@astron.com>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: tech-kern
Date: 12/21/2005 21:25:33
--dTy3Mrz/UPE2dbVg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 21, 2005 at 06:45:14PM +0000, Christos Zoulas wrote:
> In article <Pine.LNX.4.61.0512211909130.18519@m24s24.vlinux.de>,
> mount_udf:
> - The -m flag should be split to -u uid, -g gid like the other mount calls.

as replied before to Hubert, yeah this makes sense indeed.

> These are many minor nits; in general it is fine!

Thanks, i'll try to address these `nits' soon. KNF at times bites me :( 
esp. some indenting rules are not consistent/logical but try to stick to 
them. Can't say it helps readability... esp. the rules on splitting lines 
are a bit weird and the resulting code looks `funny' and isn't that 
readable to me. Normally i try to go for readability first in my indenting.

Will keep you informed,
Reinoud


--dTy3Mrz/UPE2dbVg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ6m6NYKcNwBDyKpoAQIFvAf+M84EXxZXFXxGpWXhTpensUaIFwnzvpCt
zCZYZZoTnW9p5/lVRxiqZfsjqW8lCOekgkWO7uvJOCyy20cPq3UaZNn5POq9hBRV
3MCxodJBlDYQS7n7cEmMSCsoCMDjBcvxzzbyp6sGJe6ipIvz5f+2p5E9I/7gIl2e
akF8ZxNNe+svJD/YjXRd6WDiZS7/yks2MDZEv8LleOtzDqqRWW67BXRoJeCxl3cg
SnD050OFZzZjYnQKMKT5hzcFn3tsY0S/t5sdJQ6peRtNucfRQVHSRP3BFxLze41B
v6nwkWB2R4P27giC3UsdSUYgCebCp0MAiOK40kWFdEh1HPOzmlsfkA==
=JozW
-----END PGP SIGNATURE-----

--dTy3Mrz/UPE2dbVg--