--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Dec 18, 2005 at 12:23:45PM +0000, David Laight wrote:
> On Sat, Dec 17, 2005 at 08:58:27PM -0800, Jason Thorpe wrote:
> > Reinoud's patch is somewhat reasonable...  
> > subr_disk_mbr.c:readdisklabel() is the only version of that function  
> > that does not return "no disk label" when no label is found, as far  
> > as I can tell.

true... i get the `no disk label' on my Alpha... i ought to have mentioned 
that.

> > What, exactly, depends on the semantics of it NOT returning that  
> > message?
> 
> Since the message gets written to the console, you get an annoying message
> every time you access a 'vnd' disk that contains a single filesystem,
> a raidframe partition that isn't subdivided, or a CD or ....
> 
> You also don't actually want the lack of a disklablel to be an error either.

Its no error on the disclabel retrieval/processing only an error from the 
`readdisclabel' function.

Reinoud


--Q68bSM7Ycu6FN28Q
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ6VzVIKcNwBDyKpoAQJEOAf6A19oyPN8tpt7mTrLHm4gLNW7dhlU7sJs
hpnRpuhDuGBNmT6x4uOSbbFHGM+x68RcXWIs5xOl82ZNQgD0lLJw/g3QYQyuqbaA
QPEheGYZRQho9M37BhO7QGjXdgMKh6XdCW6iSo6Ht1+arYhPrlSEOopfyfasn8lb
SuCKdA8d724dS3rwl4BclJyjldao1PfYC6CzKla4gQEKStzu00E5QpJpvsAp1V2r
IDRQQaB58A9+aqRE8k5Md9k8vPZYQxGgQU7ep3wZe+Pke8sNEuvNVPPVUWjbzY4c
eo4la2AkNSDWLItz/ZMkvRi8FIPA/f33psEcWOtzaHSbGHKKKXP1wA==
=ucWB
-----END PGP SIGNATURE-----

--Q68bSM7Ycu6FN28Q--