--WfZ7S8PLGjBY9Voh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2005.12.12 20:44:27 +0000, Rui Paulo wrote:
| On 2005.12.08 00:55:26 +0000, Iain Hibbert wrote:
| |=20
| | so, like I say - any comments welcomed..  this is not the end, or even =
the
| | beginning of the end but its getting near the end of the beginning..
|=20
| Style:
|=20
| 1) please use ANSI function declarations;
| 2) and C99 uintXX_t types.
| 3) break long lines where possible.
| 4) you seem to mix function name prefixes like "bt_" and
| "bluetooth_". why?

Forgot to mention:
5) don't use __P(). it's marked deprecated and will be removed at
some point.
6) you must convert every 'struct proc' to 'struct lwp' due to the
ktrace-lwp branch merge.
	   ex:
	     void function(struct proc *p ...) -> struct lwp *l

	   	err =3D suser(p->p_cred->pc_ucred, NULL);
	     goes to
		err =3D suser(l->l_proc->p_cred->pc_ucred, NULL);




		-- Rui Paulo

--WfZ7S8PLGjBY9Voh
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (NetBSD)

iD8DBQFDnfRkZPqyxs9FH4QRAp8iAJ0VMykDu2Ger+D118HHJtm3cSl7xACgkpM4
gxQBlbuODlxG+aloRJvrQL0=
=/L98
-----END PGP SIGNATURE-----

--WfZ7S8PLGjBY9Voh--