Subject: Re: Bluetooth protocol code
To: Iain Hibbert <plunky@rya-online.net>
From: Rui Paulo <rpaulo@fnop.net>
List: tech-kern
Date: 12/12/2005 20:44:27
--LQAwcd5tHl0Qlnzi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2005.12.08 00:55:26 +0000, Iain Hibbert wrote:
|=20
| so, like I say - any comments welcomed..  this is not the end, or even the
| beginning of the end but its getting near the end of the beginning..

Style:

1) please use ANSI function declarations;
2) and C99 uintXX_t types.
3) break long lines where possible.
4) you seem to mix function name prefixes like "bt_" and
"bluetooth_". why?

Microcode:
I think it would be better if we create a pkgsrc pkg for this.

I'm going to look at the userland tools now.

Regards,
		-- Rui Paulo

--LQAwcd5tHl0Qlnzi
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (NetBSD)

iD8DBQFDneEqZPqyxs9FH4QRAr8vAJ0WbjaLT/p9jojV6bAD1OPIXN39EwCeLJG4
OnJY+YsutdKwlz50H7RaF+Y=
=HNH1
-----END PGP SIGNATURE-----

--LQAwcd5tHl0Qlnzi--