Subject: Re: yamt-vop branch
To: None <>
From: YAMAMOTO Takashi <>
List: tech-kern
Date: 10/30/2005 00:22:32
> I looked at the changes, I have just a few comments:


> cd9660_setattr
> 	should just return EOPNOTSUPP immediately, the extra checks are silly.

i thought it's written in the manner to support r/w support in future.
isn't it the case?

> ntfs_fsync
> 	should take a (void *) argument like all the other VOPs.

i've followed the style in which most of ntfs code is written.
i'd like to leave it for jdolecek@.

> tmpfs_update
> 	should return void, since it can't fail.

i'll change.

> ffs_*
> 	should just call ffs_* directly instead of UFS_*.
> lfs_*
> 	should just call lfs_* directly instead of UFS_*.

i think it's a matter of style.  but ok, i'll change them.