Subject: Re: yamt-vop branch
To: None <firstname.lastname@example.org>
From: YAMAMOTO Takashi <email@example.com>
Date: 10/30/2005 00:22:32
> I looked at the changes, I have just a few comments:
> should just return EOPNOTSUPP immediately, the extra checks are silly.
i thought it's written in the manner to support r/w support in future.
isn't it the case?
> should take a (void *) argument like all the other VOPs.
i've followed the style in which most of ntfs code is written.
i'd like to leave it for jdolecek@.
> should return void, since it can't fail.
> should just call ffs_* directly instead of UFS_*.
> should just call lfs_* directly instead of UFS_*.
i think it's a matter of style. but ok, i'll change them.