Subject: Re: RFC: patch to change the disk I/O scheduler via dkctl(8)
To: None <email@example.com>
From: YAMAMOTO Takashi <firstname.lastname@example.org>
Date: 10/12/2005 10:32:06
> > - is there any point to change "sortmethod" on the fly?
> > it's characteristics of the device.
> I removed this, and I modified bufq_set_strat to accept
> an int argument to set the sort method in the driver
> and not via dkctl(8).
why did you leave struct disk_sched?
> > - if you create a new file for bufq_ routines,
> > it should contain bufq_alloc etc as well.
- please preserve copyright notices.
- i'd suggest subr_bufq.c.
> > - string -> BUFQ_* conversion shouldn't be done in bufq_set_strat.
> > it's better to make bufq_alloc itsself take a string.
> I could do that, but I think it's better to not modify the API
> (and a bunch of drivers), anyway I don't have any problem with
> modifying all drivers if you think it's better.
i have a patch in my local tree.
> > - bufq_set_strat seems broken.
> > have you read bufq_alloc/free?>
> I believe this is fixed in my latest patch.
it doesn't seem to be fixed. have you tested it?