Subject: Re: int/register_t mismatch
To: matthew green <mrg@eterna.com.au>
From: Bill Studenmund <wrstuden@netbsd.org>
List: tech-kern
Date: 09/06/2005 20:26:16
--GyRA7555PLgSTuth
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 05, 2005 at 10:20:05PM +1000, matthew green wrote:
>=20
> a long time ago mouse said...
>=20
>    kern/kern_descrip.c:
>   =20
>    /* ARGSUSED */
>    int
>    sys_fcntl(struct proc *p, void *v, register_t *retval)
>    {
>    ...
>    	case F_GETOWN:
>    ...
>    		error =3D (*fp->f_ops->fo_ioctl)
>    			(fp, TIOCGPGRP, (caddr_t)retval, p);
>   =20
>    Wait a second.  Isn't TIOCGPGRP expecting pointer to int, not pointer
>    to register_t?  Won't this break on big-endian LP64?
>   =20
>    Or has this been fixed since last May?
>=20
> looks like it's still a bug to me... i think this patch should work ok.
>=20
> i'll test it on i386 & sparc64 and then commit.

Looks like the right thing to do.

Take care,

Bill

--GyRA7555PLgSTuth
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFDHl3YWz+3JHUci9cRAuzLAJ9L7SF0XXJG77nqKcXU2/T+Le5NhwCfVFWx
nmjQaX9+6hnmZhdgnsV1994=
=SebU
-----END PGP SIGNATURE-----

--GyRA7555PLgSTuth--