Subject: Re: COPYIN/COPYOUT macro problems Re: IOCTL implementation and kernel/userland addresses
To: Rui Paulo <rpaulo@NetBSD.org>
From: Reinoud Zandijk <firstname.lastname@example.org>
Date: 08/25/2005 20:50:13
Content-Type: text/plain; charset=us-ascii
On Thu, Aug 25, 2005 at 05:43:51PM +0100, Rui Paulo wrote:
> | arch/pc532/fpu/ieee_handler.c
> | dist/pf/net/pf_table.c
> | dist/ipf/netinet/ip_compat.h
> | all define their own COPYIN() and COPYOUT() macro's.... now what to do?
> | a) don't use COPYIN/COPYOUT but use IOCTL_COPYIN and IOCTL_COPYOUT ?
> | b) patch somehow pc532/pf/ipf to not use such generic names?
> | c) ...
> | (a) would do justice to the fact that they are only usable for IOCTL flags
> | (b) might cause problems with importing newer pf/ipf or are those imports
> | mainly scripted?
> | (c) other suggestions?
> I vote for (a).
> For (b), you could change pc532, change ipf2netbsd script and create a new
> pf2netbsd script, but that's just too overhead for something that could be
> done easily with a name change.
true; but we do have to remember that it's name ought not be choosen too
carelessly since its propably going to stay and porting of NetBSD stuff to
other BSD's ought not to be compromised easily when it can be avoided.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
-----END PGP SIGNATURE-----