Subject: Re: CVS commit: src/sys/kern
To: None <firstname.lastname@example.org>
From: Frank van der Linden <email@example.com>
Date: 08/22/2005 21:36:23
Roland Illig wrote:
>Module Name: src
>Committed By: rillig
>Date: Mon Aug 22 15:10:50 UTC 2005
> src/sys/kern: kern_prot.c
>Bugfix: In crcmp, compare n group IDs instead of only n bytes.
>Added a big FIXME because two group lists containing the same entries,
>but ordered differently, still compare as unequal. The same holds if one
>group list contains an entry twice while the other does not. ok'ed by
The correct way to fix that remaining problem is probably to make sure
the array of group IDs is sorted, and contains no duplicates, each time
it is changed. The most important (only?) case is probably in the
setgroups system call; the array that is copied in should be sorted, and
duplicates removed, before anything else is done with it.
setgroups is an infrequent operation, so it's not expensive to do it there.