Subject: Re: Incorrect vattr passed to VOP_SYMLINK?
To: None <tech-kern@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: tech-kern
Date: 08/15/2005 18:22:48
On 8/15/05, Jason Thorpe <thorpej@shagadelic.org> wrote:
>=20
> On Aug 15, 2005, at 1:20 AM, Julio M. Merino Vidal wrote:
>=20
> > The thing is that I have a common function used by all VOPs that
> > create new nodes.  This function bases its decision on the kind of
> > object that has to be created on the value of va_type, and was
> > working fine until I added symlinks, because the attribute had
> > the VNON value.
>=20
> Why not pass the type as a separate argument to that function, and
> then just always pass VLNK in the VOP_SYMLINK() case?  That is what I
> have done in file systems on other operating systems.

Yes, of course I can do that.  I just wanted to avoid it because it seemed
redundant if va_type also held the same value (which always does except
for this specific case).

--=20
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/