Subject: Re: kern/25279: NFS read doesn't update atime
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: tech-kern
Date: 06/28/2005 15:14:04
On Tue, Jun 28, 2005 at 08:18:15PM +0900, YAMAMOTO Takashi wrote:
> can you use diff -up ?
> 
> > @@ -554,6 +557,9 @@
> >  	struct vm_page *pg;
> >  	off_t off;
> >  
> > +
> > +	ip->i_flag |= IN_UPDATE | IN_CHANGE;
> > +
> >  	if (!DOINGSOFTDEP(vp) || (ap->a_flags & PGO_CLEANIT) == 0) {
> >  		return genfs_putpages(v);
> >  	}
> 
> it seems like an overkill.
> i think that GOP_WRITE is a better place.

You mean VOP_WRITE ?
ffs_write already updates the mtime. The issue I'm trying to fix here is
that write to files via mmap() don't update the mtime. mmap() won't ever
cause VOP_WRITE(), right ?

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--