Subject: Re: Compressed vnd handling tested successfully
To: Hubert Feyrer <hubert@feyrer.de>
From: Bill Studenmund <wrstuden@netbsd.org>
List: tech-kern
Date: 06/13/2005 11:19:21
--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 13, 2005 at 01:40:13PM +0200, Hubert Feyrer wrote:
> >On Mon, 13 Jun 2005, Martin Husemann wrote:
> >>> * find someone who'll feel confident to commit the kernel code
> >>
> >>IMHO all the kernel changes need  to be conditionalized on some kernel
> >>option. There are lots of vnd users out there, most of which never will=
=20
> >>use
> >>this format.
>=20
> Looking at the code, I wonder how to do this:
>  * just add an #ifdef for a symbol around the code, and keep the
>    data fields for compression handling in struct vnd_softc
>  * put the #ifdef also on the fields in struct vnd_softc
>  * use something else than an #ifdef/option (I have no idea on kernel
>    hacking :)

I recommend option 1. Unless the crypto fields are huge, leave them in. It=
=20
will make everyone's life easier.

Take care,

Bill

--/04w6evG8XlLl3ft
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFCrc4pWz+3JHUci9cRAkutAJsFjniAWKXURGEfjmY4ii7IQdvQFQCfcQLg
YNZytnsXdnhkxEL8Vwjx/JE=
=hTKO
-----END PGP SIGNATURE-----

--/04w6evG8XlLl3ft--