Subject: Re: Compressed vnd handling tested successfully
To: Hubert Feyrer <hubert@feyrer.de>
From: Allen Briggs <briggs@netbsd.org>
List: tech-kern
Date: 06/13/2005 09:14:26
On Mon, Jun 13, 2005 at 01:40:13PM +0200, Hubert Feyrer wrote:
> Looking at the code, I wonder how to do this:
>  * just add an #ifdef for a symbol around the code, and keep the
>    data fields for compression handling in struct vnd_softc

Is there a good reason for leaving the data fields around?  (LKM
issues if the structure is shared with other parts of the kernel;
userland interface issues if the structure is shared with userland)

>  * put the #ifdef also on the fields in struct vnd_softc
>  * use something else than an #ifdef/option (I have no idea on kernel
>    hacking :)

Use the config(9) 'defflag', I think.

> Thinking more about the userland tool's name, I wonder if "vndcompress" 
> would be more appropriate than cl<something>...

I apologize if I missed something earlier, but is this something that
could be folded into vnconfig ?

-allen

-- 
                  Use NetBSD!  http://www.NetBSD.org/