Subject: Re: XF86 wsfb driver and wscons ioctl
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Nathan J. Williams <nathanw@wasabisystems.com>
List: tech-kern
Date: 01/17/2005 09:58:15
Izumi Tsutsui <tsutsui@ceres.dti.ne.jp> writes:
> - wsfb uses WSDISPLAYIO_LINEBYTES ioctl() and WSDISPLAYIO_MODE_DUMBFB
> flag for WSDISPLAYIO_SMODE to mmap(), but they were added after 2.0
> was branched.
So they were. Is that a problem? I see the point of this exercise as
improving -current in preparation for the next release, not in
rototilling old release branches.
> - IMHO, these ioctls (taken from OpenBSD?) seem really stupid.
> I think we should have more generic ioctl which returns whole info
> about MI rasops(9), which includes screen size, bitmap vaddr
> for mmap(), depth, and stride etc. rather than limited ioctls for
> LINEBYTES, DUMB or so.
I'm not entirely clear on the history of those ioctls, but for the
project I did I considered it more important to be compatible than to
try and invent something good. The idea of a better
framebuffer-describing ioctl has been tossed around occasionally on
the lists for years without much happening. I certainly wouldn't
object to something better, but I don't think it's a big deal to
implement the ioctls that wsfb wants, either.
- Nathan