Subject: Re: NetBSD, apple fibre-channel card & 2.8TB Xserve-RAID
To: der Mouse <email@example.com>
From: Charles M. Hannum <firstname.lastname@example.org>
Date: 12/10/2004 21:58:44
On Friday 10 December 2004 20:49, Mike Parker wrote:
> *bnp = blkptrtodb(ump,
> - (int32_t)ufs_rw32(ip->i_ffs1_db[bn],
> + (daddr_t)(u_int32_t)ufs_rw32(ip->i_ffs1_db[bn],
> *bnp = blkptrtodb(ump, ufs_rw64(ip->i_ffs2_db[bn],
I note that in -current, with the addition of snapshot support in May, an
intermediate variable was introduced that has the same effect as the daddr_t
cast. So, this bug does not exist in -current. This is why I didn't notice
it on my code inspection.
Also, ufs_rw32() already returns a u_int32_t, so your other cast is redundant
(besides changing it from int32_t).