Subject: Re: LKM diff for review
To: None <tech-kern@NetBSD.org>
From: Peter Postma <peter@pointless.nl>
List: tech-kern
Date: 10/25/2004 12:19:08
On Mon, Oct 25, 2004 at 12:11:12PM +0200, cube@cubidou.net wrote:
> On Mon, Oct 25, 2004 at 12:01:14PM +0200, Peter Postma wrote:
> > I'm working on cleaning up the LKM code, here's my first diff for review:
> > changes the static array to a linked list. I've been running with this diff
> > for a while now and had no problems with LKM's so far.
>
> What other changes do you have in mind?
The other changes are mostly clean up (unused code, style).
> I don't think all cleaning up on
> Earth would make our LKM subsystem suck less. Currently nobody would
> reasonably have more than a few modules so a static array is jsut fine.
>
I agree, but the diff also removes the usage of a fixed amount of RAM
(it's not much, but well... :-)
--
Peter Postma