--Apple-Mail-3-386396975
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII; format=flowed


On Sep 7, 2004, at 2:12 PM, Manuel Bouyer wrote:

> I noone object I'll commit this in a couple of days, and request a 
> pullup to
> 2.0 of all commits related to dealing with scsipi_xfer shortage.

  int
-atapi_scsipi_cmd(struct scsipi_periph *periph,
+atapi_scsipi_cmd(struct scsipi_periph *periph, struct scsipi_xfer *_xs,
      struct scsipi_generic *scsipi_cmd, int cmdlen, void *data, size_t 
datalen,
      int retries, int timeout, struct buf *bp, int flags)
  {
-	struct scsipi_xfer *xs;
+	struct scsipi_xfer *xs = _xs;

What's the point of that?  Why not just name the parameter "xs" and 
eliminate the automatic variable?

         -- Jason R. Thorpe <thorpej@wasabisystems.com>


--Apple-Mail-3-386396975
content-type: application/pgp-signature; x-mac-type=70674453;
	name=PGP.sig
content-description: This is a digitally signed message part
content-disposition: inline; filename=PGP.sig
content-transfer-encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (Darwin)

iD8DBQFBPyaxOpVKkaBm8XkRAq4hAKDC8I/odDC3BRMPtDxlAWy9QsGljwCbBJoh
ttN1d5BTCux3Jd9mluoKZC4=
=kIJL
-----END PGP SIGNATURE-----

--Apple-Mail-3-386396975--