Subject: Re: dev/scsipi/ch.c:chattach() fix ? (and approval for commit?)
To: Charles M. Hannum <abuse@spamalicious.com>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: tech-kern
Date: 06/17/2004 11:27:45
On Thu, Jun 17, 2004 at 03:12:49AM +0000, Charles M. Hannum wrote:
> On Thursday 17 June 2004 01:28, Stoned Elipot wrote:
> > On Thu, Jun 17, 2004 at 12:41:03AM +0000, Charles M. Hannum wrote:
> > [SNIP]
> >
> > > Nope.  The problem is that ch_interpret_sense() is eating the UNIT
> > > ATTENTION.

Arg, I missed this function ! Must have done a typo when I did a search in
vi :(

> >
> > Hum so...
> > I'm surely not understanding the issue(s) but I tried the following patch
> > (ie without the dummy scsipi_test_unit_ready() call) and now it reads:
> 
> I was on my way out when I wrote that earlier.
> 
> I would just remove this block of code in ch.c:
> 
>                 if ((periph->periph_flags & PERIPH_OPEN) == 0) {
>                         /*
>                          * if the device is not yet open, we can ignore this
>                          * information.
>                          */
>                         return (0);
>                 }
> 
> That should fix the problem by letting the normal mid-layer code retry the 
> command.

Yes, just removing this block is the right thing to do.
Stoned, please test this, and if it work for you, commit.

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--