Subject: Re: dev/scsipi/ch.c:chattach() fix ? (and approval for commit?)
To: Stoned Elipot <seb@ssr.univ-paris7.fr>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: tech-kern
Date: 06/17/2004 00:07:38
--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 16, 2004 at 11:20:36PM +0200, Manuel Bouyer wrote:
> Hum. Can you apply the attached patch and see if there's any message for ch0 ?
> This is to make sure that this changer doesn't return any sense at all.

With the patch this time.

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff

--- scsipi_base.c.orig	2004-06-16 23:16:55.000000000 +0200
+++ scsipi_base.c	2004-06-16 23:18:33.000000000 +0200
@@ -810,8 +810,8 @@
 #endif
 
 	sense = &xs->sense.scsi_sense;
-#ifdef SCSIPI_DEBUG
-	if (periph->periph_flags & SCSIPI_DB1) {
+#if 1 /* #ifdef SCSIPI_DEBUG */
+	if (/* periph->periph_flags & SCSIPI_DB1 */ 1) {
 		int count;
 		scsipi_printaddr(periph);
 		printf(" sense debug information:\n");
@@ -1724,6 +1724,9 @@
 	int flags, error;
 	struct scsipi_sense cmd;
 
+	scsipi_printaddr(periph);
+	printf("requesting sense\n");
+
 	periph->periph_flags |= PERIPH_SENSE;
 
 	/* if command was polling, request sense will too */

--mP3DRpeJDSE+ciuQ--