Subject: Re: LK_SHARED for VFS_VGET/FHTOVP
To: YAMAMOTO Takashi <email@example.com>
From: Bill Studenmund <firstname.lastname@example.org>
Date: 05/26/2004 16:37:09
Content-Type: text/plain; charset=us-ascii
On Thu, May 27, 2004 at 04:43:15AM +0900, YAMAMOTO Takashi wrote:
> > Specifically with using exclusive locks, I think that the vnode system =
> > fine-grained. Perhaps not the best locking (we can get better paralleli=
> > perhaps), but correct. By changing things so we need big-lock, we take =
> > step back.
> what's "the vnode system"?
> the vnode interface itsself, or eachfilesystem implementation,
> or something else?
Both the interface and our file system implementations.
> > Over the years the vnode interface has gotten a reputation for being
> > complicated and troublesome. When I was at NASA, I worked on cleaning l=
> > of it up, and among other things we got production-ready layered file
> > systems. Part of getting things to work was being an ass about locking,
> > and making sure we did locking right in all places. "Right" meant=20
> > documenting what should happen and auditing all the code to match. To g=
> > back to a comment you made about me believing documentation, I actually=
> > tried to make sure the code and documentation matched (what I think=20
> > "should" happen). :-)
> > By encouraging us to break what documentation we have, we open the door=
> > getting back into an untrusted, confusing mess. For instance, new=20
> > developers have to just "know" that it's "ok" to use shared locks for=
> > reads, but not anything else.
> documented where?
sys/kern/vnode_if.src. Yes, it does not explicitly state that locked state=
=3D=3D exclusive, however until Chuck's change nothing used shared locks. S=
before that it'd have seemed like stating the obvious.
> > 2) We don't know how bad things are. Sure, ffs_read() (and lfs_read()) =
> > only call ufs_update(), which is "ok" as long as we have big-lock. But =
> > don't _know_ what the other file systems do, and what problems they hav=
> > we haven't audited the other code. This uncertainty is one of my big
> > concerns about things.
> have you audited all of our filesystems at some point before Chuck changed
> the code to use LK_SHARED?
No. And AFAICT Chuck didn't perform the audit either. That's one of my=20
concerns. We have no idea what assumptions have been broken.
> > Oh, as an aside, I think in your patch you unlock at one point and then=
> > re-lock with LK_SHARED. I think all you need to do is call VOP_LOCK() w=
> > LK_DOWNGRADE or something like it - you can downgrade the exclusive loc=
> > into a shared one. Also, since you have the exclusive lock, you can jus=
> > use VOP_LOCK() as no one will have initiated reclaiming in the mean tim=
> i think it's bad idea to allow to use arbitrary fancy lockmgr flags
> for VOP_LOCK.
Why? At one point I'd have agreed with you. At this point, however, I
think we "know" that we have lockmgr locks. We might as well use lockmgr
to our benefit. Hmm... need to look at unionfs to see if it's happy with
shared locks and downgrade.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)
-----END PGP SIGNATURE-----