Subject: Re: CVS commit: src/sys/dev/scsipi
To: Manuel Bouyer <>
From: Bill Studenmund <>
List: tech-kern
Date: 05/01/2004 22:04:16
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 27, 2004 at 06:15:37PM +0000, Manuel Bouyer wrote:
> Module Name:	src
> Committed By:	bouyer
> Date:		Tue Apr 27 18:15:37 UTC 2004
> Modified Files:
> 	src/sys/dev/scsipi: scsipi_base.c
> Log Message:
> Revert part of 1.102:
> Don't decrease/check xs_retries when the device report "Power On, Reset, =
> Bus Device Reset" sense condition, just retry the command. The initial bus
> reset would cause the first TEST_UNIT_READY to report this condition,
> and as xs_retries is set to 0 when XS_CTL_DISCOVERY is set, it would repo=
rt an
> error instead of being retried, causing the disk probe to report "drive
> offline" instead of the geometry and capacity. Checking/decreasing
> xs_retries on the bus reset reported by the adapter is enouth to avoid the
> problem reported by rev 1.102.
> Problem analysed by Paul Kranenburg, fix confirmed by Anders Hjalmars,
> and explaination as to why the INQUIRY wasn't affected by this provided by
> Bill Studenmund.

I think we need to do more with this code. I think we should change the=20
test to do the same thing for all ascq <=3D 0x07, not just =3D=3D 0x00. The=
prefered behavior on reset now is to return either 0x29/0x01 (device=20
reset) or 0x29/0x07 (I_T Nexus Loss) for the first command. The difference=
is if you know you lost the I_T Nexus, you do 0x29/0x07, otherwise you do=


Take care,


Content-Type: application/pgp-signature
Content-Disposition: inline

Version: GnuPG v1.2.3 (NetBSD)